Re: [PATCH 10/14] revert: Persist data for continuation

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 6, 2011, 21:20 UTC
Message-ID: <7vsjqjjebq.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110706100119.GG15682@elie>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 14 quoted lines

>  /*
>   * Example:
>   *
>   *	struct commit_list *list;
>   *	struct commit_list **next = &list;
>   *
>   *	next = commit_list_append(c1, next);
>   *	next = commit_list_append(c2, next);
>   *	*next = NULL;
>   *	assert(commit_list_count(list) == 2);
>   *	return list;
>   *
>   * Don't forget to NULL-terminate!
>   */

I wonder if the optimization to allow omitting unnecessary NULL termination inside a tight loop by the caller is really worth the potential trouble, though.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.