From: Junio C Hamano Date: Wed, 06 Jul 2011 21:20:57 GMT Subject: Re: [PATCH 10/14] revert: Persist data for continuation Message-ID: <7vsjqjjebq.fsf@alter.siamese.dyndns.org> In-Reply-To: <20110706100119.GG15682@elie> Jonathan Nieder writes: > /* > * Example: > * > * struct commit_list *list; > * struct commit_list **next = &list; > * > * next = commit_list_append(c1, next); > * next = commit_list_append(c2, next); > * *next = NULL; > * assert(commit_list_count(list) == 2); > * return list; > * > * Don't forget to NULL-terminate! > */ I wonder if the optimization to allow omitting unnecessary NULL termination inside a tight loop by the caller is really worth the potential trouble, though.