Re: [PATCH 07/14] revert: Introduce struct to keep command-line options

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jul 6, 2011, 12:06 UTC
Message-ID: <20110706120616.GQ15682@elie>
In-Reply-To: <CALkWK0=gm-y3CB83TsSiWWF4qyS5hOJDhOYCz4HTWyT7iHP6MA@mail.gmail.com>

Ramkumar Ramachandra wrote:

> My justification: in later steps, we'd want to be able to mix
> "pick" and "revert" instructions in the same instruction sheet.  This
> will essentially require the parser to return a commit + a replay_opts
> struct (which will contain the action information).

Side note: is it intended to support insns like

 pick A..B

Anyway, the above explanation about the intended use for "struct replay_opts" (it needs to be small, I guess?) would be a good thing to add to the commit message, too. Basically, whatever information a person needs in order to understand the design is a useful thing to add.

[...]

> Yes, I'm definitely considering exposing parse_args in the future,
> especially since I want to support command-line options in my
> instruction sheet.

Hm, I am not sure what to think about this direction (is the git sequencer actually just a fast git shell? in that case, why is pick spelled "pick" instead of "cherry-pick"?). Maybe it's a good thing.

Thanks for some useful clarifications.