git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk: refresh the index before running diff-files

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 1, 2012, 22:54 UTC
Message-ID
<7vsj9xajn1.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20121001223237.GC12496@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 5 quoted lines
> I don't buy the "gitk should be read-only" argument from that thread. I
> think we decided a while back[1] that the stat cache is not really a
> user-visible modification; you're not updating the index in any
> meaningful way that impacts the user's workflow, but merely refreshing
> our cache of what is in the filesystem.

I think it is OK as long as a failure to "update-index --refresh" does not lead to a user-visible error (I think we made sure that the the opportunistic refresh "git diff" and "git status" does won't report an error, when you are trying to help your co-worker by visiting her repository and running these commands, only to peek).

Previous: Jeff KingNext: Junio C Hamano
Message 15 of 18 in “Git diff-file bug?”
  1. Scott BatchelorSep 28, 2012
  2. Jeff KingSep 28, 2012
  3. gitk: refresh the index before running diff-filesJeff King, Sep 28, 2012
  4. Junio C HamanoSep 28, 2012
  5. Andreas SchwabSep 28, 2012
  6. Jeff KingSep 28, 2012
  7. Junio C HamanoSep 28, 2012
  8. Jeff KingSep 28, 2012
  9. Junio C HamanoSep 28, 2012
  10. Andreas SchwabSep 28, 2012
  11. Paul MackerrasSep 30, 2012
  12. Jeff KingSep 30, 2012
  13. Jonathan NiederSep 30, 2012
  14. Jeff KingOct 1, 2012
  15. Junio C HamanoOct 1, 2012
  16. Junio C HamanoSep 28, 2012
  17. Scott BatchelorOct 3, 2012
  18. Drew NorthupOct 3, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.