Re: [PATCH] gitk: refresh the index before running diff-files

From: Jeff King <peff@peff.net>
Date: Sep 30, 2012, 01:42 UTC
Message-ID: <20120930014203.GA10664@sigill.intra.peff.net>
In-Reply-To: <20120930000527.GB4852@bloggs.ozlabs.ibm.com>

On Sun, Sep 30, 2012 at 10:05:27AM +1000, Paul Mackerras wrote:

Show 15 quoted lines

> On Fri, Sep 28, 2012 at 04:50:54PM -0400, Jeff King wrote:
> 
> > +proc refresh_index {} {
> > +    global need_index_refresh
> > +    if { $need_index_refresh } {
> > +	exec sh -c "git update-index --refresh >/dev/null 2>&1 || true"
> > +	set need_index_refresh false
> > +    }
> > +}
> 
> Unfortunately this will wait for the git update-index command to
> complete, making the GUI unresponsive while it executes, and that can
> take minutes on a large repository (e.g. the linux kernel) on a
> machine with a slow disk and a cold disk cache.  We will need to make
> the git update-index execute asynchronously.

Good point. We're getting out of my very limited tcl cargo-culting skills now, so I'll let somebody more clueful do that fix.

-Peff