Re: [PATCH] gitk: refresh the index before running diff-files

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 28, 2012, 23:02 UTC
Message-ID: <7vipaxkayf.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120928223152.GA7906@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 16 quoted lines

> On Sat, Sep 29, 2012 at 12:11:58AM +0200, Andreas Schwab wrote:
>
>> Jeff King <peff@peff.net> writes:
>> 
>> > +proc refresh_index {} {
>> > +    global need_index_refresh
>> > +    if { $need_index_refresh } {
>> > +	exec sh -c "git update-index --refresh >/dev/null 2>&1 || true"
>> 
>> I think the usual idiom for ignoring errors is to use catch around exec,
>> avoiding the extra shell wrapper:
>> 
>>         catch { exec git update-index --refresh }
>
> Thanks. I don't speak tcl at all, but your version makes much more
> sense.

But isn't the redirection still needed? Otherwise the "Needs update" messages will go to the terminal, no?