Re: [PATCH] gitk: refresh the index before running diff-files

From: Jeff King <peff@peff.net>
Date: Sep 28, 2012, 22:31 UTC
Message-ID: <20120928223152.GA7906@sigill.intra.peff.net>
In-Reply-To: <m24nmh4x1t.fsf@igel.home>

On Sat, Sep 29, 2012 at 12:11:58AM +0200, Andreas Schwab wrote:

Show 11 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > +proc refresh_index {} {
> > +    global need_index_refresh
> > +    if { $need_index_refresh } {
> > +	exec sh -c "git update-index --refresh >/dev/null 2>&1 || true"
> 
> I think the usual idiom for ignoring errors is to use catch around exec,
> avoiding the extra shell wrapper:
> 
>         catch { exec git update-index --refresh }

Thanks. I don't speak tcl at all, but your version makes much more sense.

-Peff