Re: [PATCH] gitk: refresh the index before running diff-files

From: Jeff King <peff@peff.net>
Date: Sep 28, 2012, 23:04 UTC
Message-ID: <20120928230410.GA9851@sigill.intra.peff.net>
In-Reply-To: <7vipaxkayf.fsf@alter.siamese.dyndns.org>

On Fri, Sep 28, 2012 at 04:02:32PM -0700, Junio C Hamano wrote:

Show 17 quoted lines

> >> Jeff King <peff@peff.net> writes:
> >> 
> >> > +proc refresh_index {} {
> >> > +    global need_index_refresh
> >> > +    if { $need_index_refresh } {
> >> > +	exec sh -c "git update-index --refresh >/dev/null 2>&1 || true"
> >> 
> >> I think the usual idiom for ignoring errors is to use catch around exec,
> >> avoiding the extra shell wrapper:
> >> 
> >>         catch { exec git update-index --refresh }
> >
> > Thanks. I don't speak tcl at all, but your version makes much more
> > sense.
> 
> But isn't the redirection still needed?  Otherwise the "Needs
> update" messages will go to the terminal, no?

I think the weird tcl-catches-stderr thing kicks in (at least it did for me in a simple experiment). But like I said, I am not an expert.

-Peff