git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 07/13] remote-hg: redirect buggy mercurial output

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 4, 2013, 16:29 UTC
Message-ID
<7vr4iqjm3y.fsf@alter.siamese.dyndns.org>
In-Reply-To
<515d9741985ca_69fd13fde181671a@nysa.mail>
Felipe Contreras <felipe.contreras@gmail.com> writes:
Show 14 quoted lines
> I saw that you update the commit message without consulting here first to:
>
> ---
> remote-hg: redirect unnecessary mercurial output
>     
> Mercurial emits messages like "searching for changes", "no changes
> found", etc. meant for the use of its own UI layer, which is of no
> use for our remote helper.  Squelch them.
> ---
>
> This is not correct. This patch does _not_ squelch the output, it's redirecting
> it to standard error, so the user actually sees it now, and we do that not
> because the output is "unnecessary", but because it *breaks* the pipe between
> the transport helper and remote helper. I'll reroll with the updated commit message.

I actually "consulted" by asking you what you meant by "buggy". I just misread/misunderstood your response in prose.

An update in the patch form obviously would not risk such a misunderstanding ;-)

Thanks.
Previous: Felipe ContrerasNext: Felipe Contreras
Message 13 of 48 in “remote-hg: general updates”
  1. 00/13 remote-hg: general updatesFelipe Contreras, Apr 2, 2013
  2. 01/13 remote-hg: trivial cleanupsFelipe Contreras, Apr 2, 2013
  3. 02/13 remote-hg: add missing config variable in docFelipe Contreras, Apr 2, 2013
  4. 03/13 remote-hg: properly report errors on bookmark pushesFelipe Contreras, Apr 2, 2013
  5. 04/13 remote-hg: fix for files with spacesFelipe Contreras, Apr 2, 2013
  6. 05/13 remote-hg: make sure fake bookmarks are updatedFelipe Contreras, Apr 2, 2013
  7. 06/13 remote-hg: trivial test cleanupsFelipe Contreras, Apr 2, 2013
  8. 07/13 remote-hg: redirect buggy mercurial outputFelipe Contreras, Apr 2, 2013
  9. Junio C HamanoApr 2, 2013
  10. Felipe ContrerasApr 2, 2013
  11. Junio C HamanoApr 2, 2013
  12. Felipe ContrerasApr 4, 2013
  13. Junio C HamanoApr 4, 2013
  14. 08/13 remote-hg: split bookmark handlingFelipe Contreras, Apr 2, 2013
  15. 09/13 remote-hg: refactor exportFelipe Contreras, Apr 2, 2013
  16. 10/13 remote-hg: update remote bookmarksFelipe Contreras, Apr 2, 2013
  17. 11/13 remote-hg: force remote pushFelipe Contreras, Apr 2, 2013
  18. 12/13 remote-hg: don't update bookmarks unnecessarilyFelipe Contreras, Apr 2, 2013
  19. 13/13 remote-hg: update tags globallyFelipe Contreras, Apr 2, 2013
  20. Junio C HamanoApr 2, 2013
  21. Felipe ContrerasApr 2, 2013
  22. Junio C HamanoApr 2, 2013
  23. John KeepingApr 2, 2013
  24. Max HornApr 2, 2013
  25. Felipe ContrerasApr 3, 2013
  26. Felipe ContrerasApr 3, 2013
  27. Antoine PelisseApr 3, 2013
  28. Felipe ContrerasApr 5, 2013
  29. Max HornApr 4, 2013
  30. Felipe ContrerasApr 4, 2013
  31. Felipe ContrerasApr 4, 2013
  32. Max HornApr 4, 2013
  33. Felipe ContrerasApr 4, 2013
  34. Max HornApr 5, 2013
  35. Felipe ContrerasApr 6, 2013
  36. Philip OakleyApr 6, 2013
  37. Felipe ContrerasApr 6, 2013
  38. Junio C HamanoApr 6, 2013
  39. Felipe ContrerasApr 6, 2013
  40. Junio C HamanoApr 7, 2013
  41. Jed BrownApr 4, 2013
  42. Junio C HamanoApr 4, 2013
  43. Jed BrownApr 4, 2013
  44. Felipe ContrerasApr 4, 2013
  45. Felipe ContrerasApr 4, 2013
  46. Jed BrownApr 4, 2013
  47. Felipe ContrerasApr 4, 2013
  48. Felipe ContrerasApr 5, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.