Re: [PATCH 07/13] remote-hg: redirect buggy mercurial output

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 2, 2013, 19:58 UTC
Message-ID: <7vehesd7rl.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1364929382-1399-8-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

> We can't use stdout for that in remote helpers.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---

You may want to clarify "buggy output" a bit. Will mercurial forever be broken? Some versions of Hg emit [[[it is unclear for Junio to tell what it is to fill this blank]]] to its output that we want to ignore?

Show 15 quoted lines

>  contrib/remote-helpers/git-remote-hg | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg
> index b200e60..874ccd4 100755
> --- a/contrib/remote-helpers/git-remote-hg
> +++ b/contrib/remote-helpers/git-remote-hg
> @@ -271,6 +271,7 @@ def get_repo(url, alias):
>  
>      myui = ui.ui()
>      myui.setconfig('ui', 'interactive', 'off')
> +    myui.fout = sys.stderr
>  
>      if hg.islocal(url):
>          repo = hg.repository(myui, url)