Re: [PATCH 07/13] remote-hg: redirect buggy mercurial output

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 2, 2013, 20:22 UTC
Message-ID: <CAMP44s1C37+drw3HhysO4aRgxUt=knAKnT+Bk0JCqLr=CL5yjQ@mail.gmail.com>
In-Reply-To: <7vehesd7rl.fsf@alter.siamese.dyndns.org>

On Tue, Apr 2, 2013 at 1:58 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 11 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> We can't use stdout for that in remote helpers.
>>
>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>> ---
>
> You may want to clarify "buggy output" a bit.  Will mercurial
> forever be broken?  Some versions of Hg emit [[[it is unclear for
> Junio to tell what it is to fill this blank]]] to its output that
> we want to ignore?

The problem is that mercurial's code is kind of hardcoded to run under mercurial's UI, so it throws messages around willynillingly, like:

searching for changes no changes found

And they can't be turned off. Theoretically we could override mercurial's UI class, but I think that has the potential to create more problems, it's not worth at this point in time.

Cheers.

-- 
Felipe Contreras