From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 04 Apr 2013 16:29:05 GMT
Subject: Re: [PATCH 07/13] remote-hg: redirect buggy mercurial output
Message-ID: <7vr4iqjm3y.fsf@alter.siamese.dyndns.org>
In-Reply-To: <515d9741985ca_69fd13fde181671a@nysa.mail>

Felipe Contreras <felipe.contreras@gmail.com> writes:

> I saw that you update the commit message without consulting here first to:
>
> ---
> remote-hg: redirect unnecessary mercurial output
>     
> Mercurial emits messages like "searching for changes", "no changes
> found", etc. meant for the use of its own UI layer, which is of no
> use for our remote helper.  Squelch them.
> ---
>
> This is not correct. This patch does _not_ squelch the output, it's redirecting
> it to standard error, so the user actually sees it now, and we do that not
> because the output is "unnecessary", but because it *breaks* the pipe between
> the transport helper and remote helper. I'll reroll with the updated commit message.

I actually "consulted" by asking you what you meant by "buggy".  I
just misread/misunderstood your response in prose.

An update in the patch form obviously would not risk such a
misunderstanding ;-)

Thanks.