Re: [PATCH 07/13] remote-hg: redirect buggy mercurial output

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 2, 2013, 20:36 UTC
Message-ID: <7v8v50brfn.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAMP44s1C37+drw3HhysO4aRgxUt=knAKnT+Bk0JCqLr=CL5yjQ@mail.gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 22 quoted lines

> On Tue, Apr 2, 2013 at 1:58 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>> We can't use stdout for that in remote helpers.
>>>
>>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>>> ---
>>
>> You may want to clarify "buggy output" a bit.  Will mercurial
>> forever be broken?  Some versions of Hg emit [[[it is unclear for
>> Junio to tell what it is to fill this blank]]] to its output that
>> we want to ignore?
>
> The problem is that mercurial's code is kind of hardcoded to run under
> mercurial's UI, so it throws messages around willynillingly, like:
>
> searching for changes
> no changes found
>
> And they can't be turned off. Theoretically we could override
> mercurial's UI class, but I think that has the potential to create
> more problems, it's not worth at this point in time.

Oh, I totally agree with you _after_ reading that explanation.

You just shouldn't let me waste your time to explain that to me in this exchange, and you could have done so by writing a clearer log message. That's all.

>
> Cheers.