git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/2] send-email: make annotate configurable

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 7, 2013, 03:32 UTC
Message-ID
<7vr4in818e.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1365239012-15079-2-git-send-email-felipe.contreras@gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
Show 5 quoted lines
> @@ -305,6 +306,7 @@ my $rc = GetOptions("h" => \$help,
>  		    "smtp-domain:s" => \$smtp_domain,
>  		    "identity=s" => \$identity,
>  		    "annotate" => \$annotate,
> +		    "no-annotate" => \$no_annotate,

Wouldn't it be much better to let GetOptions know that --no-annotate is allowed by saying

	"annotate!" => \$annotate
which also let us lose an extra $no_annotate variable?
Previous: Felipe ContrerasNext: Felipe Contreras
Message 3 of 12 in “send-email: couple of improvements”
  1. 0/2 send-email: couple of improvementsFelipe Contreras, Apr 6, 2013
  2. 1/2 send-email: make annotate configurableFelipe Contreras, Apr 6, 2013
  3. Junio C HamanoApr 7, 2013
  4. Felipe ContrerasApr 7, 2013
  5. 2/2 format-patch: add format.cover-letter configurationFelipe Contreras, Apr 6, 2013
  6. Ramkumar RamachandraApr 6, 2013
  7. Felipe ContrerasApr 6, 2013
  8. Matthieu MoyApr 6, 2013
  9. Matthieu MoyApr 6, 2013
  10. Junio C HamanoApr 7, 2013
  11. Felipe ContrerasApr 7, 2013
  12. Matthieu MoyApr 6, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.