Re: [PATCH v2 1/2] send-email: make annotate configurable

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 7, 2013, 06:54 UTC
Message-ID: <CAMP44s1+XDQNctRe_N1u=cmF+e83bzu4LFK6GUaz-UKagvYLBg@mail.gmail.com>
In-Reply-To: <7vr4in818e.fsf@alter.siamese.dyndns.org>

On Sat, Apr 6, 2013 at 9:32 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 14 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> @@ -305,6 +306,7 @@ my $rc = GetOptions("h" => \$help,
>>                   "smtp-domain:s" => \$smtp_domain,
>>                   "identity=s" => \$identity,
>>                   "annotate" => \$annotate,
>> +                 "no-annotate" => \$no_annotate,
>
> Wouldn't it be much better to let GetOptions know that --no-annotate
> is allowed by saying
>
>         "annotate!" => \$annotate
>
> which also let us lose an extra $no_annotate variable?

Right. Will resend.

-- 
Felipe Contreras