From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 07 Apr 2013 03:32:17 GMT
Subject: Re: [PATCH v2 1/2] send-email: make annotate configurable
Message-ID: <7vr4in818e.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1365239012-15079-2-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

> @@ -305,6 +306,7 @@ my $rc = GetOptions("h" => \$help,
>  		    "smtp-domain:s" => \$smtp_domain,
>  		    "identity=s" => \$identity,
>  		    "annotate" => \$annotate,
> +		    "no-annotate" => \$no_annotate,

Wouldn't it be much better to let GetOptions know that --no-annotate
is allowed by saying

	"annotate!" => \$annotate

which also let us lose an extra $no_annotate variable?