Re: [PATCH v2 2/2] format-patch: add format.cover-letter configuration

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 6, 2013, 16:02 UTC
Message-ID: <CAMP44s0Zzdb-1A0ej5Ly_501sv0OOOrHi86GWT9NYkndbiggeg@mail.gmail.com>
In-Reply-To: <CALkWK0kMTt6wDv6sUVe9CbX-WSx=XH+PF6eQ6oXYFjcp_Yi+aQ@mail.gmail.com>

On Sat, Apr 6, 2013 at 6:43 AM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:

Show 18 quoted lines

> Felipe Contreras wrote:
>> Also, add a new option: 'auto', so if there's more than one patch, the
>> cover letter is generated, otherwise it's not.
>
> Awesome!  I wanted to fix this myself, but got sidetracked with the
> whole submodules thing.
>
>> +format.cover-letter::
>> +       Allows to configure the --cover-letter option of format-patch by
>> +       default. In addition, you can set it to 'auto' to automatically
>> +       determine based on the number of patches (generate if there's more than
>> +       one).
>> +
>
> Perhaps you can clarify this: Controls whether to generate a
> cover-letter when format-patch is invoked.  Can be true, false, or
> auto.  "auto" generates a cover-letter only when generating more than
> one patch.

That's good, but I believe if we say it's a boolean, true and false are implied, and then we have an extra "auto".

-- 
Felipe Contreras