git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] format-patch: add format.cover-letter configuration

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Apr 6, 2013, 17:43 UTC
Message-ID
<vpq8v4vimhn.fsf@grenoble-inp.fr>
In-Reply-To
<CAMP44s0Zzdb-1A0ej5Ly_501sv0OOOrHi86GWT9NYkndbiggeg@mail.gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
Show 7 quoted lines
>> Perhaps you can clarify this: Controls whether to generate a
>> cover-letter when format-patch is invoked.  Can be true, false, or
>> auto.  "auto" generates a cover-letter only when generating more than
>> one patch.
>
> That's good, but I believe if we say it's a boolean, true and false
> are implied, and then we have an extra "auto".

At the moment, we don't say it's Boolean. I'm not sure it's a good idea to say Boolean here, since it would also imply that there's no value other than true and false.

Also, you should mention the default value. Something like "Set to true to always generate a cover letter. Defaults to false." or so.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Felipe ContrerasNext: Matthieu Moy
Message 8 of 12 in “send-email: couple of improvements”
  1. 0/2 send-email: couple of improvementsFelipe Contreras, Apr 6, 2013
  2. 1/2 send-email: make annotate configurableFelipe Contreras, Apr 6, 2013
  3. Junio C HamanoApr 7, 2013
  4. Felipe ContrerasApr 7, 2013
  5. 2/2 format-patch: add format.cover-letter configurationFelipe Contreras, Apr 6, 2013
  6. Ramkumar RamachandraApr 6, 2013
  7. Felipe ContrerasApr 6, 2013
  8. Matthieu MoyApr 6, 2013
  9. Matthieu MoyApr 6, 2013
  10. Junio C HamanoApr 7, 2013
  11. Felipe ContrerasApr 7, 2013
  12. Matthieu MoyApr 6, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.