Re: [PATCH] Fix off by one error in prep_exclude.

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 28, 2008, 08:46 UTC
Message-ID: <7vprvmuykw.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <479D805E.3000209@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

Show 13 quoted lines

> The "problem" is not only with git-clean, but also in others, like
> git-ls-files. Try this in you favorite repository:
>
>    $ git ls-files -o /*bin
>
> The output does not make a lot of sense. (Here it lists the contents of
> /bin and /sbin.) Not that it hurts with ls-files, but
>
>    $ git clean -f /
>
> is basically a synonym for
>
>    $ rm -rf /

Yeah, /*bin is not inside the repository so it should not even be reported as "others". Shouldn't the commands detect this and reject feeding such paths outside the work tree to the core, which always expect you to talk about paths inside?

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.