Re: [PATCH] Fix off by one error in prep_exclude.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 28, 2008, 09:22 UTC
- Message-ID
- <7vlk6auwxs.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <479D9ADE.6010003@viscovery.net>
Johannes Sixt <j.sixt@viscovery.net> writes:
Show 10 quoted lines
> Junio C Hamano schrieb: > ... >> Yeah, /*bin is not inside the repository so it should not even >> be reported as "others". Shouldn't the commands detect this and >> reject feeding such paths outside the work tree to the core, >> which always expect you to talk about paths inside? > > That's what I had expected. But look: > ... > Some mechanism for this is already there; it's just not complete enough.
Exactly. That was what I've been getting at from the beginning of this thread --- fix for that incompleteness is what's needed.