From: Junio C Hamano Date: Mon, 28 Jan 2008 08:46:39 GMT Subject: Re: [PATCH] Fix off by one error in prep_exclude. Message-ID: <7vprvmuykw.fsf@gitster.siamese.dyndns.org> In-Reply-To: <479D805E.3000209@viscovery.net> Johannes Sixt writes: > The "problem" is not only with git-clean, but also in others, like > git-ls-files. Try this in you favorite repository: > > $ git ls-files -o /*bin > > The output does not make a lot of sense. (Here it lists the contents of > /bin and /sbin.) Not that it hurts with ls-files, but > > $ git clean -f / > > is basically a synonym for > > $ rm -rf / Yeah, /*bin is not inside the repository so it should not even be reported as "others". Shouldn't the commands detect this and reject feeding such paths outside the work tree to the core, which always expect you to talk about paths inside?