Re: [PATCH] More test cases for sanitized path names

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 1, 2008, 10:22 UTC
Message-ID: <7v63x99dt9.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <200802011010.41938.robin.rosenberg.lists@dewire.com>

Robin Rosenberg <robin.rosenberg.lists@dewire.com> writes:

Show 8 quoted lines

>> > +test_expect_failure 'add a directory outside the work tree' '
>> > +	d1="$(cd .. ; pwd)" &&
>> > +	git add "$d1"
>> > +	echo $?
>> > +'
>
> Oops. Remove the echo $?. It still fails, i.e. git add succeeds when
> it shouldn't. I was double checking it just before sending the patch.

Ah, you found breakages.

I could not quite tell what you meant by these tests with test_expect_failure, either they were misuse or "currently fails but they shouldn't". Coming up with a small reproducible failure case is 50% of solving the problem. That's very appreciated.

In any case, I think the large-ish test framework update patch I sent tonight should go in very early post 1.5.4 cycle, so plesae use the new-and-improved test_expect_failure to mark these reproducible failure cases. Also, there is no need for hurry for you to just send test cases without fixes. When I say I do not take patches early, I do mean it --- I do not even take _my_ own patches like the one you are following up on. I've sent quite a many of them, and I think some are on 'pu' or 'offcuts', but most are only in the list archive. If nobody cares deeply enough about them to test and resend with Tested-by: , I am not planning to go back to pick them up.

Show 7 quoted lines

>>  * First, the obvious one.  You are creating a garbage file
>>    outside of t/trash directory.  Don't.  If you need to, dig a
>>    test directory one level lower inside t/trash and play around
>>    there.
>
> Can we move the default trash one level down for all tests? That
> would give us one free level to play with.

I'd rather not. Most tests do not have to step outside and it is very handy to debug any breakage they find by always being able to go there with "cd t/trash".