Re: [PATCH] Fix off by one error in prep_exclude.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 27, 2008, 20:44 UTC
Message-ID: <alpine.LSU.1.00.0801272043040.23907@racer.site>
In-Reply-To: <1201463731-1963-1-git-send-email-shawn.bohrer@gmail.com>

Hi,

On Sun, 27 Jan 2008, Shawn Bohrer wrote:

Show 7 quoted lines

> base + current already includes the trailing slash so adding
> one removes the first character of the next directory.
> 
> Signed-off-by: Shawn Bohrer <shawn.bohrer@gmail.com>
> ---
> 
> This fixes the oops part of the issue Johannes found,

have I?

> but doesn't address the fact that we probably should remove files that 
> aren't a part of the repository at in the first place.

I am sorry, but I cannot begin to see what this commit tries to accomplish. Yes, sure, there is an off-by-one error, and your commit message says how that was fixed. But I miss a description what usage it would affect, i.e. when this bug triggers.

I imagine that you would be as lost as me, reading that commit message 6 months from now, trying to understand why that change was made.

Ciao, Dscho