Re: [PATCH 2/2] receive-pack: Add receive.denyObjectLimit to refuse push with too many objects

From: Junio C Hamano <gitster@pobox.com>
Date: May 13, 2011, 17:09 UTC
Message-ID: <7vpqnm7cim.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201105131854.31540.johan@herland.net>

Johan Herland <johan@herland.net> writes:

> The new receive.denyObjectLimit config variable defines an upper limit on the
> number of objects to accept in a single push. If the number of objects in a
> push exceeds this limit, the entire push is immediately aborted without
> storing the pushed objects on the server at all.

Where does the error message go? Can clients pushing over various transports receive the reason without your server consuming the data from them? Don't you want to "receive-in-core-and-discard" instead?

For the purpose of "preventing an accidental push", I suspect that people would expect you to limit either by number of commits (i.e. depth of history) or by the total size of the data being transferred.

The name "objectlimit" sounds as if you are doing the latter and we can use "200MB" there, but you are only limiting by count, so it is somewhat misleading. We would want to see "count" or "number" somewhere in its name.