[PATCH] Windows: add a wrapper for the shutdown() system call
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- May 18, 2011, 20:24 UTC
- Message-ID
- <4DD42B05.9050000@kdbg.org>
- In-Reply-To
- <20110517055605.GE10048@sigill.intra.peff.net>
Even though Windows's socket functions look like their POSIX counter parts, they do not operate on file descriptors, but on "socket objects". To bring the functions in line with POSIX, we have proxy functions that wrap and unwrap the socket objects in file descriptors using open_osfhandle and get_osfhandle. But shutdown() was not proxied, yet. Fix this.
Signed-off-by: Johannes Sixt <j6t@kdbg.org> --- Am 17.05.2011 07:56, schrieb Jeff King:
Show 7 quoted lines
> On Mon, May 16, 2011 at 10:02:16PM +0200, Johannes Sixt wrote: > >>> + if (git_connection_is_socket(conn)) >>> + shutdown(fd[0], SHUT_WR); >> >> We probably need a wrapper for shutdown() on Windows. I'll look into >> this tomorrow.
We have a shutdown() on Windows, but it does not work out of the box. Making it work is not a big deal, but it is an academic excercise if it were only for this topic: On Windows, send-pack hangs when network connections are involved for unknown reasons as long as side-band-64k is enabled. If it is not enabled, the deadlock that you fixed does not happen in the first place and it is irrelevant whether shutdown works.
> FWIW, we already make an identical call in transport-helper.c (I was > tempted even to use "1" instead of SHUT_WR for portability, but it seems > nobody has complained so far about the use in transport-helper).
Yes, and for the reasons mentioned above, this patch is intended for the 1.7.4 series, where transport-helper.c went public. (But it should apply cleanly to current master as well.) We do not have tests that exercise the code in transport-helper.c, but I did test that this shutdown implementation does something reasonable when it is merged with your send-pack deadlock topic branch.
compat/mingw.c | 7 +++++++ compat/mingw.h | 3 +++ 2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/compat/mingw.c b/compat/mingw.c index bee6054..1cbc9e8 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -1219,6 +1219,13 @@ int mingw_setsockopt(int sockfd, int lvl, int optname, void *optval, int optlen) return setsockopt(s, lvl, optname, (const char*)optval, optlen); } +#undef shutdown +int mingw_shutdown(int sockfd, int how) +{ + SOCKET s = (SOCKET)_get_osfhandle(sockfd); + return shutdown(s, how); +} + #undef listen int mingw_listen(int sockfd, int backlog) { diff --git a/compat/mingw.h b/compat/mingw.h index 14211c6..3b20fa9 100644 --- a/compat/mingw.h +++ b/compat/mingw.h @@ -219,6 +219,9 @@ int mingw_bind(int sockfd, struct sockaddr *sa, size_t sz); int mingw_setsockopt(int sockfd, int lvl, int optname, void *optval, int optlen); #define setsockopt mingw_setsockopt +int mingw_shutdown(int sockfd, int how); +#define shutdown mingw_shutdown + int mingw_listen(int sockfd, int backlog); #define listen mingw_listen
-- 1.7.5.rc1.97.ge0653