Re: [PATCHv2 2/2] receive-pack: Add receive.objectCountLimit to refuse push with too many objects
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 14, 2011, 17:50 UTC
- Message-ID
- <7voc355fz9.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <BANLkTik_taBK+=nh+0WEUjp3AV_fC7e_dg@mail.gmail.com>
Shawn Pearce <spearce@spearce.org> writes:
> If we are going to put limits in, does it make sense to try and push > these limits back to pack-objects in a more detailed way? You talked > about depth of history, or size of pack. pack-objects could > approximate both.
I think the receiving end switches between index-pack and unpack-objects based on the object count, but if we can add a protocol extension to carry these estimates from the sender, we would be much better off. A large push with a small number of objects would want to keep everything in a pack, for example, but currently there is no way to do so.