From: Junio C Hamano Date: Sun, 07 Jul 2013 17:53:03 GMT Subject: Re: [PATCH] prompt: do not double-discriminate detached HEAD Message-ID: <7vppuu45q8.fsf@alter.siamese.dyndns.org> In-Reply-To: John Szakmeister writes: > On Sun, Jul 7, 2013 at 8:52 AM, Ramkumar Ramachandra wrote: >> When GIT_PS1_SHOWCOLORHINTS is turned on, there is no need to put a >> detached HEAD within parenthesis: the color can be used to discriminate >> the detached HEAD. >> >> Signed-off-by: Ramkumar Ramachandra >> --- >> For cuteness :) > > Personally, I'd rather see the parens kept. Not everyone sees red > very well--I know several people who can't see it at all, and it keeps > it consistent with non-colored output. +1; I find red on many terminal emulators to be too dark to tell, especially in a small font, from black myself.