git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Ship sample hooks with .sample suffix

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 25, 2008, 02:48 UTC
Message-ID
<7vod5q8c25.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<7vtzfi8dvk.fsf_-_@gitster.siamese.dyndns.org>

I'll queue the patch to 'master' and I suspect that this will make 31d6632 (Windows: Change the name of hook scripts to make them not executable., 2007-11-30) unnecessary.

I've looked at diff between ee1e0a3 (the original "pull" request) and 8fd39ba (after WS fixup on borrowed code and other changes).

They all looked fine except for git.c::main() where do .. while does not have a { } around the body (which is not required by C language but it just looked funny).

I am very tempted to pull MinGW series directly to 'master', or at least to 'next', perhaps after dropping 31d6632. What's your confidence level on the series? I think we should give this series extra priority so that any potential issues with other series (like dr/ceil) that do pathname traversal will become more apparent sooner rather than later.

Previous: Junio C HamanoNext: Johannes Sixt
Message 16 of 21 in “pre-commit hook should ignore carriage returns at EOL”
  1. pre-commit hook should ignore carriage returns at EOLChristian Holtje, Jun 24, 2008
  2. Alf ClementJun 24, 2008
  3. Ian HiltJun 24, 2008
  4. Jakub NarebskiJun 24, 2008
  5. Ian HiltJun 24, 2008
  6. Jakub NarebskiJun 24, 2008
  7. Ian HiltJun 24, 2008
  8. Christian HoltjeJun 24, 2008
  9. Junio C HamanoJun 24, 2008
  10. Christian HoltjeJun 24, 2008
  11. Jakub NarebskiJun 24, 2008
  12. Junio C HamanoJun 24, 2008
  13. Christian HoltjeJun 25, 2008
  14. Junio C HamanoJun 24, 2008
  15. Ship sample hooks with .sample suffixJunio C Hamano, Jun 25, 2008
  16. Junio C HamanoJun 25, 2008
  17. Johannes SixtJun 25, 2008
  18. Junio C HamanoJun 25, 2008
  19. Johannes SixtJun 26, 2008
  20. Junio C HamanoJun 26, 2008
  21. Peter BaumannJun 25, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.