Re: [PATCH] pre-commit hook should ignore carriage returns at EOL
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Jun 24, 2008, 19:05 UTC
- Message-ID
- <m363rylknc.fsf@localhost.localdomain>
- In-Reply-To
- <alpine.LFD.1.10.0806241418360.32759@sys-0.hiltweb.site>
Ian Hilt <Ian.Hilt@gmx.com> writes:
> On Tue, 24 Jun 2008 at 12:23pm -0400, Christian Holtje wrote:
Show 12 quoted lines
> > --- a/templates/hooks--pre-commit
> > +++ b/templates/hooks--pre-commit
> > @@ -55,8 +55,14 @@ perl -e '
> > if (s/^\+//) {
> > $lineno++;
> > chomp;
> > - if (/\s$/) {
> > - bad_line("trailing whitespace", $_);
> > + if (/\r$/) {
>
> Wouldn't it be less redundant to do a test for \s\r$ here instead of
> testing for \r$ and then \s\r$?I don't think so, because you want next to test for whitespace where it _doesn't_ end in \r, i.e. this condition is here because of the 'else' clause. IIRC.
-- Jakub Narebski Poland ShadeHawk on #git