Re: [PATCH] Ship sample hooks with .sample suffix
- From
- Peter Baumann <waste.manager@gmx.de>
- Date
- Jun 25, 2008, 05:18 UTC
- Message-ID
- <20080625051854.GA11813@m62s10.vlinux.de>
- In-Reply-To
- <7vtzfi8dvk.fsf_-_@gitster.siamese.dyndns.org>
On Tue, Jun 24, 2008 at 07:09:03PM -0700, Junio C Hamano wrote:
Show 8 quoted lines
> We used to mark hooks we ship as samples by making them unexecutable, but > some filesystems cannot tell what is executable and what is not. > > This makes it much more explicit. The hooks are suffixed with .sample > (but now are made executable), so enabling it is still one step operation > (instead of "chmod +x $hook", you would do "mv $hook.sample $hook") but > now they won't get accidentally enabled on systems without executable bit. >
Wouldn't it be better to name the hooks $hook.deactivated so its obvious to anybody that they are not executed? Just my 2 cents.
-Peter