Re: [PATCH] pre-commit hook should ignore carriage returns at EOL

From: Ian Hilt <ian.hilt@gmx.com>
Date: Jun 24, 2008, 19:54 UTC
Message-ID: <alpine.LFD.1.10.0806241548140.32759@sys-0.hiltweb.site>
In-Reply-To: <m363rylknc.fsf@localhost.localdomain>

On Tue, 24 Jun 2008 at 12:05pm -0700, Jakub Narebski wrote:

> I don't think so, because you want next to test for whitespace
> where it _doesn't_ end in \r, i.e. this condition is here
> because of the 'else' clause.  IIRC.

What I'm suggesting is this,

	if (/\s\r$/) {
		bad_line("trailing whitespace", $_);
	} else {
		if (/\s$/) {
			bad_line("trailing whitespace", $_);
		}
	}

Why only test for \r when all you want to know is whether there is whitespace before \r ? If there isn't whitespace and \r at the end of a line, then only test for whitespace at the end of a line.

-- 
Ian Hilt
Ian.Hilt (at) gmx.com
GnuPG key: 0x4AFC1EE3