From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 25 Jun 2008 02:48:18 GMT
Subject: Re: [PATCH] Ship sample hooks with .sample suffix
Message-ID: <7vod5q8c25.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <7vtzfi8dvk.fsf_-_@gitster.siamese.dyndns.org>

I'll queue the patch to 'master' and I suspect that this will make 31d6632
(Windows: Change the name of hook scripts to make them not executable.,
2007-11-30) unnecessary.

I've looked at diff between ee1e0a3 (the original "pull" request) and
8fd39ba (after WS fixup on borrowed code and other changes).

They all looked fine except for git.c::main() where do .. while does not
have a { } around the body (which is not required by C language but it
just looked funny).

I am very tempted to pull MinGW series directly to 'master', or at least
to 'next', perhaps after dropping 31d6632.  What's your confidence level
on the series?  I think we should give this series extra priority so that
any potential issues with other series (like dr/ceil) that do pathname
traversal will become more apparent sooner rather than later.