git/list[1] front-page[2] threads[3] people[4] search[5] about
 

http-fetch segfault fix?

From
Junio C Hamano <junkio@cox.net>
Date
Jun 7, 2006, 05:35 UTC
Message-ID
<7vlks9le8b.fsf_-_@assigned-by-dhcp.cox.net>
In-Reply-To
<1149619097.25298.6.camel@dv>
Pavel Roskin <proski@gnu.org> writes:
Show 9 quoted lines
> It's a different backtrace this time.  abort_object_request() has this code:
>
> if (obj_req->slot) {
>      release_active_slot(obj_req->slot);
>      obj_req->slot = NULL;
> }
>
> Apparently just because obj_req->slot is not NULL doesn't mean it's a
> valid pointer.  I'm going to use Valgrind now.

Nick's one-liner to explicitly initialize newreq->slot to NULL looks obviously correct to me. Does it fix this problem for you?

Previous: Pavel RoskinNext: Pavel Roskin
Message 12 of 16 in “New release?”
  1. Junio C HamanoJun 6, 2006
  2. Johannes SchindelinJun 6, 2006
  3. Junio C HamanoJun 6, 2006
  4. Johannes SchindelinJun 6, 2006
  5. Junio C HamanoJun 6, 2006
  6. Jon LoeligerJun 6, 2006
  7. Junio C HamanoJun 6, 2006
  8. Jon LoeligerJun 6, 2006
  9. Pavel RoskinJun 6, 2006
  10. Nick HengeveldJun 6, 2006
  11. Pavel RoskinJun 6, 2006
  12. http-fetch segfault fix?Junio C Hamano, Jun 7, 2006
  13. Pavel RoskinJun 7, 2006
  14. Junio C HamanoJun 7, 2006
  15. Pavel RoskinJun 7, 2006
  16. Nick HengeveldJun 7, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.