git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: http-fetch segfault fix?

From
PRPavel Roskin <proski@gnu.org>
Date
Jun 7, 2006, 14:29 UTC
Message-ID
<1149690584.19551.2.camel@dv>
In-Reply-To
<7vhd2xld77.fsf@assigned-by-dhcp.cox.net>
On Tue, 2006-06-06 at 22:58 -0700, Junio C Hamano wrote:
Show 17 quoted lines
> Pavel Roskin <proski@gnu.org> writes:
> 
> > The Valgrind diagnostics confirms that obj_req->slot is not initialized
> > (as opposed to being a pointer to a freed area or something else):
> >
> > ==27182== Conditional jump or move depends on uninitialised value(s)
> > ==27182==    at 0x4070EA: abort_object_request (http-fetch.c:1059)
> > ==27182==    by 0x4071CE: fetch_object (http-fetch.c:1078)
> > ==27182==    by 0x4073EC: fetch (http-fetch.c:1126)
> > ==27182==    by 0x403125: loop (fetch.c:180)
> > ==27182==    by 0x403369: pull (fetch.c:248)
> > ==27182==    by 0x407A13: main (http-fetch.c:1271)
> >
> > Line 1059 is:
> > if (obj_req->slot) {
> 
> Thanks.  That is indeed a very good sign.

Both git-clone instances (with and without USE_CURL_MULTI) have completed successfully on http://www.denx.de/git/linux-2.6-denx.git

Nick, thank you for fixing this bug!
-- 
Regards,
Pavel Roskin
Previous: Junio C HamanoNext: Nick Hengeveld
Message 15 of 16 in “New release?”
  1. Junio C HamanoJun 6, 2006
  2. Johannes SchindelinJun 6, 2006
  3. Junio C HamanoJun 6, 2006
  4. Johannes SchindelinJun 6, 2006
  5. Junio C HamanoJun 6, 2006
  6. Jon LoeligerJun 6, 2006
  7. Junio C HamanoJun 6, 2006
  8. Jon LoeligerJun 6, 2006
  9. Pavel RoskinJun 6, 2006
  10. Nick HengeveldJun 6, 2006
  11. Pavel RoskinJun 6, 2006
  12. http-fetch segfault fix?Junio C Hamano, Jun 7, 2006
  13. Pavel RoskinJun 7, 2006
  14. Junio C HamanoJun 7, 2006
  15. Pavel RoskinJun 7, 2006
  16. Nick HengeveldJun 7, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.