git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] graph API: fix bug in graph_is_interesting()

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 18, 2009, 23:53 UTC
Message-ID
<7vk5103chi.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20090818211812.GL8147@facebook.com>
Adam Simpkins <simpkins@facebook.com> writes:
> -	return (commit->object.flags & (UNINTERESTING | TREESAME)) ? 0 : 1;
> +	return simplify_commit(graph->revs, commit) == commit_show;

If you do this after revision.c finished the traversal (e.g. "limited" case), I think it should be Ok.

But calling simplify_commit() while the traversal is still in progress is asking for trouble. I do not recall the details anymore but when I tried to make the "simplify-merges" algorithm incremental, I had seen funny breakage caused by calling simplify_commit() twice on the same commit.

I suspect that this change will break the primary traversal.
Previous: Adam SimpkinsNext: Adam Simpkins
Message 3 of 14 in “RE: interaction between --graph and --simplify-by-decoration”
  1. Adam SimpkinsAug 18, 2009
  2. graph API: fix bug in graph_is_interesting()Adam Simpkins, Aug 18, 2009
  3. Junio C HamanoAug 18, 2009
  4. Adam SimpkinsAug 19, 2009
  5. Adam SimpkinsAug 19, 2009
  6. Junio C HamanoAug 19, 2009
  7. Junio C HamanoAug 19, 2009
  8. Adam SimpkinsAug 19, 2009
  9. Add test case for rev-list --parents --show-allAdam Simpkins, Aug 19, 2009
  10. Junio C HamanoAug 20, 2009
  11. Add tests for rev-list --graph with options that simplify historyAdam Simpkins, Aug 21, 2009
  12. Junio C HamanoAug 21, 2009
  13. Adam SimpkinsAug 21, 2009
  14. Santi BéjarAug 21, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.