Re: [PATCH] graph API: fix bug in graph_is_interesting()

From: Adam Simpkins <simpkins@facebook.com>
Date: Aug 19, 2009, 22:55 UTC
Message-ID: <20090819225547.GR8147@facebook.com>
In-Reply-To: <7v4os41frm.fsf@alter.siamese.dyndns.org>

On Tue, Aug 18, 2009 at 11:25:49PM -0700, Junio C Hamano wrote:

Show 15 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> >
> > When simplify_commit() logic (now called get_comit_action()) decides to
> > show this commit because revs->show_all was specified, we did not rewrite
> > its parents, but now we will?
> 
> That is, here is what I meant...
> 
> -	if (action == commit_show && revs->prune && revs->dense && want_ancestry(revs)) {
> +	if (action == commit_show &&
> +	    !revs->show_all &&
> +	    revs->prune && revs->dense && want_ancestry(revs)) {
> 
> We may want to add some tests to demonstrate the breakage this fix
> addresses.

Yes, you're right. Thanks for catching that. I'll submit a test case that checks this scenario.

-- 
Adam Simpkins
simpkins@facebook.com