RE: interaction between --graph and --simplify-by-decoration

From: Adam Simpkins <adam@adamsimpkins.net>
Date: Aug 18, 2009, 20:55 UTC
Message-ID: <1250628954.114121983@192.168.1.201>

On Friday, July 31, 2009 4:11am, "Santi Béjar" <santi@agolina.net> said:

Show 5 quoted lines

> Hello,
> 
>   I've found that in some cases the --graph and
> --simplify-by-decoration don't work well together. If you do this in
> the git.git repository:

Thanks for reporting the problem, I apologize for taking so long to investigate and respond.

> * | | f29ac4f (tag: v1.6.3-rc2) GIT 1.6.3-rc2
>  / /
> | | *   66996ec Sync with 1.6.2.4

> you can see that f29ac4f looks like it does not have any parents while
> the correct parent is 66996ec which seems to have no children. But if
> you omit the --oneline you can see that there are a lot of "root"-like
> commits (f01f109, a48f5d7, f29ac4f,...).

Yes, there's a bug in graph_is_interesting(). When processing f29ac4f, the graph code thinks that 66996ec isn't interesting and won't get displayed in the output, so it doesn't prepare the graph lines to show lines to 66996ec.

I'll submit a patch shortly.

-- Adam Simpkins adam@adamsimpkins.net