From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 18 Aug 2009 23:53:45 GMT
Subject: Re: [PATCH] graph API: fix bug in graph_is_interesting()
Message-ID: <7vk5103chi.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20090818211812.GL8147@facebook.com>

Adam Simpkins <simpkins@facebook.com> writes:

> -	return (commit->object.flags & (UNINTERESTING | TREESAME)) ? 0 : 1;
> +	return simplify_commit(graph->revs, commit) == commit_show;

If you do this after revision.c finished the traversal (e.g. "limited"
case), I think it should be Ok.

But calling simplify_commit() while the traversal is still in progress is
asking for trouble.  I do not recall the details anymore but when I tried
to make the "simplify-merges" algorithm incremental, I had seen funny
breakage caused by calling simplify_commit() twice on the same commit.

I suspect that this change will break the primary traversal.