git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add test case for rev-list --parents --show-all

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 20, 2009, 04:13 UTC
Message-ID
<7v7hwzt94p.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20090819225852.GA21187@facebook.com>
Adam Simpkins <simpkins@facebook.com> writes:
Show 11 quoted lines
> This test case ensures that rev-list --parents --show-all gets the
> parent history correct.  Normally, --parents rewrites parent history to
> skip TREESAME parents.  However, --show-all causes TREESAME parents to
> still be included in the revision list, so the parents should still be
> included too.
>
> Signed-off-by: Adam Simpkins <simpkins@facebook.com>
> ---
>
> Looking through the code, I believe TREESAME commits are the only ones
> affected by my earlier bug in simplify_commit().

What I meant was actually a test for the graph part (i.e. the problem we would see if we did not apply your update to graph_is_interesting()), but protecting the simplify_commit() logic with test from breakage is a good thing to do as well.

Thanks.
Previous: Adam SimpkinsNext: Adam Simpkins
Message 10 of 14 in “RE: interaction between --graph and --simplify-by-decoration”
  1. Adam SimpkinsAug 18, 2009
  2. graph API: fix bug in graph_is_interesting()Adam Simpkins, Aug 18, 2009
  3. Junio C HamanoAug 18, 2009
  4. Adam SimpkinsAug 19, 2009
  5. Adam SimpkinsAug 19, 2009
  6. Junio C HamanoAug 19, 2009
  7. Junio C HamanoAug 19, 2009
  8. Adam SimpkinsAug 19, 2009
  9. Add test case for rev-list --parents --show-allAdam Simpkins, Aug 19, 2009
  10. Junio C HamanoAug 20, 2009
  11. Add tests for rev-list --graph with options that simplify historyAdam Simpkins, Aug 21, 2009
  12. Junio C HamanoAug 21, 2009
  13. Adam SimpkinsAug 21, 2009
  14. Santi BéjarAug 21, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.