git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] Move pathspec validation into interactive_add

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 24, 2007, 19:15 UTC
Message-ID
<7vir3rqwts.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<1195908922-88023-3-git-send-email-win@wincent.com>
Wincent Colaiuta <win@wincent.com> writes:
> Instead of throwing away the return status of pathspec_match() I am
> keeping it, and any successful match breaks out of the loop early.

Leaving it early before checking if all the given pathspecs are used defeats the whole "error-unmatch" business, doesn't it?

> Another issue is that simple shell shortcuts don't work, so something
> as simple as "git-add -i ." will report:
>
>   error: pathspec '.' did not match any file(s) known to git.

The sample code snippet I sent you probably is not doing get_pathspec() before using the "pattern" thing. And I suspect that ...

> Likewise it's not possible to validate pathspecs like "\*.sh" either,
... may be related to that.
Previous: Wincent ColaiutaNext: Wincent Colaiuta
Message 16 of 18 in “git-add--interactive pathspec and patch additions”
  1. git-add--interactive pathspec and patch additionsWincent Colaiuta, Nov 23, 2007
  2. 1/7 Add -q/--quiet switch to git-ls-filesWincent Colaiuta, Nov 23, 2007
  3. 2/7 Rename patch_update_file function to patch_update_pathspecWincent Colaiuta, Nov 23, 2007
  4. 3/7 Add path-limiting to git-add--interactiveWincent Colaiuta, Nov 23, 2007
  5. 4/7 Bail if user supplies an invalid pathspecWincent Colaiuta, Nov 23, 2007
  6. 5/7 Teach builtin-add to pass path arguments to git-add--interactiveWincent Colaiuta, Nov 23, 2007
  7. 6/7 Add "--patch" option to git-add--interactiveWincent Colaiuta, Nov 23, 2007
  8. 7/7 Teach builtin-add to handle "--patch" optionWincent Colaiuta, Nov 23, 2007
  9. Wincent ColaiutaNov 23, 2007
  10. Junio C HamanoNov 23, 2007
  11. Wincent ColaiutaNov 23, 2007
  12. 0/3 Updates to git-add--interactiveWincent Colaiuta, Nov 24, 2007
  13. 1/3 Rename patch_update_file function to patch_update_pathspecWincent Colaiuta, Nov 24, 2007
  14. 2/3 Move pathspec validation into interactive_addWincent Colaiuta, Nov 24, 2007
  15. 3/3 Add "--patch" option to git-add--interactiveWincent Colaiuta, Nov 24, 2007
  16. Junio C HamanoNov 24, 2007
  17. Wincent ColaiutaNov 24, 2007
  18. Junio C HamanoNov 24, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.