git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] Updates to git-add--interactive

From
Wincent Colaiuta <win@wincent.com>
Date
Nov 24, 2007, 12:55 UTC
Message-ID
<1195908922-88023-1-git-send-email-win@wincent.com>
In-Reply-To
<7vk5o8smaf.fsf@gitster.siamese.dyndns.org>

Based on feedback from Junio last night here is a new series. This one goes on top of the "next" branch.

I moved the pathspec validity checking into builtin-add, thus simplifying things considerably. I also enforced some strict assumptions about how the optional arguments will be passed from builtin-add to git-add--interactive; I can do this because it is the only caller, and it once again makes things a bit simpler.

I don't expect this to actually be applied as-is, as there are some doubts I have which I have added to the emails for each patch. In particular there is a performance issue with the pathspec validity checking (no idea why it is so much slower than just invoking git-ls-files), and the behaviour is not exactly where I'd like it to be (things like "git-add -i ." don't work because "." is considered invalid).

So looking for feedback on how to address this issues and will resubmit.
Previous: Wincent ColaiutaNext: Wincent Colaiuta
Message 12 of 18 in “git-add--interactive pathspec and patch additions”
  1. git-add--interactive pathspec and patch additionsWincent Colaiuta, Nov 23, 2007
  2. 1/7 Add -q/--quiet switch to git-ls-filesWincent Colaiuta, Nov 23, 2007
  3. 2/7 Rename patch_update_file function to patch_update_pathspecWincent Colaiuta, Nov 23, 2007
  4. 3/7 Add path-limiting to git-add--interactiveWincent Colaiuta, Nov 23, 2007
  5. 4/7 Bail if user supplies an invalid pathspecWincent Colaiuta, Nov 23, 2007
  6. 5/7 Teach builtin-add to pass path arguments to git-add--interactiveWincent Colaiuta, Nov 23, 2007
  7. 6/7 Add "--patch" option to git-add--interactiveWincent Colaiuta, Nov 23, 2007
  8. 7/7 Teach builtin-add to handle "--patch" optionWincent Colaiuta, Nov 23, 2007
  9. Wincent ColaiutaNov 23, 2007
  10. Junio C HamanoNov 23, 2007
  11. Wincent ColaiutaNov 23, 2007
  12. 0/3 Updates to git-add--interactiveWincent Colaiuta, Nov 24, 2007
  13. 1/3 Rename patch_update_file function to patch_update_pathspecWincent Colaiuta, Nov 24, 2007
  14. 2/3 Move pathspec validation into interactive_addWincent Colaiuta, Nov 24, 2007
  15. 3/3 Add "--patch" option to git-add--interactiveWincent Colaiuta, Nov 24, 2007
  16. Junio C HamanoNov 24, 2007
  17. Wincent ColaiutaNov 24, 2007
  18. Junio C HamanoNov 24, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.