From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 24 Nov 2007 19:15:27 GMT
Subject: Re: [PATCH 2/3] Move pathspec validation into interactive_add
Message-ID: <7vir3rqwts.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1195908922-88023-3-git-send-email-win@wincent.com>

Wincent Colaiuta <win@wincent.com> writes:


> Instead of throwing away the return status of pathspec_match() I am
> keeping it, and any successful match breaks out of the loop early.

Leaving it early before checking if all the given pathspecs are
used defeats the whole "error-unmatch" business, doesn't it?

> Another issue is that simple shell shortcuts don't work, so something
> as simple as "git-add -i ." will report:
>
>   error: pathspec '.' did not match any file(s) known to git.

The sample code snippet I sent you probably is not doing 
get_pathspec() before using the "pattern" thing.  And I suspect
that ...

> Likewise it's not possible to validate pathspecs like "\*.sh" either,

... may be related to that.