Re: [PATCH v2] Make git send-email accept $EDITOR with arguments

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 21, 2007, 17:02 UTC
Message-ID: <7vhcic9e17.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1198237002-21470-1-git-send-email-hendeby@isy.liu.se>

Gustaf Hendeby <hendeby@isy.liu.se> writes:

> Junio, even if this is technically not a bug fix, it would be nice to
> get this fix into the 1.5.4 so that the usage of $EDITOR becomes more
> consistent throughout git.

I can buy that, but at least a single line comment in front of that system() explaining why this is safe to do so would be beneficial. I suspect that somebody would propose moving $compse_filename inside $GIT_DIR, now people realized $compose_filename is currently "./.msg.$$", and $GIT_DIR could be anything. Quotemeta would probably be better as the code you are touching won't be affected by a future change to the value of that constant defined far away in the source.