Re: [PATCH] Move git send-email cover letter temporary file to $GIT_DIR
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 22, 2007, 08:52 UTC
- Message-ID
- <7vd4szyuva.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <ee77f5c20712212304s598d344dg41d03f58084d794e@mail.gmail.com>
"David Symonds" <dsymonds@gmail.com> writes:
Show 15 quoted lines
> On Dec 22, 2007 5:49 PM, Junio C Hamano <gitster@pobox.com> wrote: >> >> "David Symonds" <dsymonds@gmail.com> writes: >> >> > On Dec 22, 2007 12:09 PM, Junio C Hamano <gitster@pobox.com> wrote: >> >> Don't you have $repo (an instance of Git) at that point? You >> >> should be able to ask repo_path() about it, shouldn't you? >> > >> > Isn't git-send-email still useful outside a Git repo? >> >> Then why does it run "rev-parse --git-dir"? > > I'm suggesting that it should still function just fine without being > inside a repo, so it should adequately handle "rev-parse --git-dir" > returning 128.
Ah, true. Then the current behaviour to use the $(pwd) for temporary file area would be Ok for now.