git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Move git send-email cover letter temporary file to $GIT_DIR

From
Gustaf Hendeby <hendeby@isy.liu.se>
Date
Dec 22, 2007, 00:43 UTC
Message-ID
<1198284202-20666-1-git-send-email-hendeby@isy.liu.se>
In-Reply-To
<7vhcic9e17.fsf@gitster.siamese.dyndns.org>

git send-email with the --compose option now puts its temporary file in $GIT_DIR instead of the current working directory. The file should be removed on exit, still it is nice not to mess around in the working directory if not necessary.

Signed-off-by: Gustaf Hendeby <hendeby@isy.liu.se>
---
 git-send-email.perl |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index e47994a..c4eae9d 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -150,9 +150,6 @@ my $auth;
 sub unique_email_list(@);
 sub cleanup_compose_files();
 
-# Constants (essentially)
-my $compose_filename = ".msg.$$";
-
 # Variables we fill in automatically, or via prompting:
 my (@to,@cc,@initial_cc,@bcclist,@xh,
 	$initial_reply_to,$initial_subject,@files,$author,$sender,$compose,$time);
@@ -170,6 +167,11 @@ if ($@) {
 	$term = new FakeTerm "$@: going non-interactive";
 }
 
+# Constants (essentially)
+my $compose_filename = $repo->command(qw/rev-parse --git-dir/);
+chomp($compose_filename);
+$compose_filename =  $compose_filename . "/.msg.$$";
+
 # Behavior modification variables
 my ($quiet, $dry_run) = (0, 0);
 
-- 
1.5.4.rc1.16.gc817f
Previous: Junio C HamanoNext: Junio C Hamano
Message 13 of 19 in “Make git send-email accept $EDITOR with arguments”
  1. Make git send-email accept $EDITOR with argumentsGustaf Hendeby, Dec 20, 2007
  2. Luciano RochaDec 20, 2007
  3. Make git send-email accept $EDITOR with argumentsGustaf Hendeby, Dec 21, 2007
  4. Jeff KingDec 21, 2007
  5. Gustaf HendebyDec 21, 2007
  6. Jeff KingDec 21, 2007
  7. Gustaf HendebyDec 21, 2007
  8. Junio C HamanoDec 21, 2007
  9. Make git send-email accept $EDITOR with argumentsGustaf Hendeby, Dec 22, 2007
  10. Junio C HamanoDec 22, 2007
  11. Gustaf HendebyDec 22, 2007
  12. Junio C HamanoDec 21, 2007
  13. Move git send-email cover letter temporary file to $GIT_DIRGustaf Hendeby, Dec 22, 2007
  14. Junio C HamanoDec 22, 2007
  15. David SymondsDec 22, 2007
  16. Junio C HamanoDec 22, 2007
  17. David SymondsDec 22, 2007
  18. Junio C HamanoDec 22, 2007
  19. Gustaf HendebyDec 22, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.