Re: [PATCH v2] Make git send-email accept $EDITOR with arguments

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 21, 2007, 21:17 UTC
Message-ID: <7vd4sz4uii.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <476C2B2E.1080801@isy.liu.se>

Gustaf Hendeby <hendeby@isy.liu.se> writes:

Show 11 quoted lines

> On 2007-12-21 20:23, Jeff King wrote:
> 
>> I am fine with using the shell. Though keep in mind that the two
>> solutions will behave differently with
>> 
>>   EDITOR='foo; bar'
>> 
>> That is, system("$editor $message") will actually invoke the shell,
>> whereas system(split(/ /, $editor), $message) will _just_ split on
>> whitespace. We should do whatever is consistent with the rest of the git
>> commands (off the top of my head, I don't know).

Personally, I think EDITOR='foo; bar' is a user shooting his foot off which we do not care about.

> A quick look at the proposed solution to the similar problem with git
> commit, using code now in git tag, it seems it uses a split like
> solution, though taking " and ' quoting into consideration.

I think the easiest to read and compatible way is:

	system('sh', '-c', '$0 $@', $editor, $filename)