[PATCH] Make git send-email accept $EDITOR with arguments
- From
Gustaf Hendeby <hendeby@isy.liu.se>
- Date
- Dec 20, 2007, 20:14 UTC
- Message-ID
- <1198181646-28632-1-git-send-email-hendeby@isy.liu.se>
Currently git send-email does not accept $EDITOR with arguments, eg, emacs -nw, when starting an editor to produce a cover letter. This fixes this in the simplest way possible, assume all spaces separates either the command from the first argument, or two arguments. This should work in most cases, but will break with quoted strings embedded spaces. An example of a problematic case is when there is a space in the path to the command.
Signed-off-by: Gustaf Hendeby <hendeby@isy.liu.se> ---
This is related to the problems recently observed in the built in git commit and git tag. I guess the behavior of git send-email has been the same from the start, but having it treat $EDITOR substantially different from that of git commit and git tag seems like bug or at least something that should be avoided.
I'm not completely satisfied with the problem with embedded spaces, but my Perl skills aren't good enough to do anything about it. If anyone have any suggestions on how to do it, it would be greatly appreciated. None-the-less, even with this shortcoming, I think this is a step in the right direction.
git-send-email.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl index 248d035..47ae77c 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -400,7 +400,7 @@ EOT close(C); my $editor = $ENV{GIT_EDITOR} || $repo->config("core.editor") || $ENV{VISUAL} || $ENV{EDITOR} || "vi"; - system($editor, $compose_filename); + system((split ' ', $editor), $compose_filename); open(C2,">",$compose_filename . ".final") or die "Failed to open $compose_filename.final : " . $!;
-- 1.5.4.rc1.3.gc641f