Re: [PATCH v4 0/6] Support triangular workflows
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 28, 2013, 16:54 UTC
- Message-ID
- <7vhajvv51f.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20130328153547.GA3337@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 10 quoted lines
> Sometimes it's annoyingly verbose to break down a compound function. But > I think in this case, you can make your tests more robust by just > checking the affirmative that the ref is still where we expect it to be, > like: > > check_push_result up_repo $the_first_commit heads/master > > Sorry if that was a bit long-winded. I think that practically speaking, > it is not a likely source of problems in this case. But it's an > anti-pattern in our tests that I think is worth mentioning.
Thanks. That is one of the reasons why we do not want to see too many custom test helper functions.