git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 0/6] Support triangular workflows

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
Mar 31, 2013, 20:51 UTC
Message-ID
<CALkWK0=a0wmUe-rjK8Gg8izc0FdXYzChSrgp+W-JNsECsDf+yA@mail.gmail.com>
In-Reply-To
<20130328153547.GA3337@sigill.intra.peff.net>
Jeff King wrote:
> [...]

So, you're saying: don't test compound statements for failure, since anything in the chain could fail and propagate failure. I should only test simple git-foo commands for failure?

Show 6 quoted lines
> Sometimes it's annoyingly verbose to break down a compound function. But
> I think in this case, you can make your tests more robust by just
> checking the affirmative that the ref is still where we expect it to be,
> like:
>
>   check_push_result up_repo $the_first_commit heads/master

Doesn't that change the meaning of the test though? I really like how the original tests read.

Previous: Junio C HamanoNext: Jeff King
Message 16 of 18 in “Support triangular workflows”
  1. 0/6 Support triangular workflowsRamkumar Ramachandra, Mar 28, 2013
  2. 1/6 remote.c: simplify a bit of code using git_config_string()Ramkumar Ramachandra, Mar 28, 2013
  3. 2/6 t5516 (fetch-push): update test descriptionRamkumar Ramachandra, Mar 28, 2013
  4. 3/6 t5516 (fetch-push): drop implicit arguments from helper functionsRamkumar Ramachandra, Mar 28, 2013
  5. 4/6 remote.c: introduce a way to have different remotes for fetch/pushRamkumar Ramachandra, Mar 28, 2013
  6. 5/6 remote.c: introduce remote.pushdefaultRamkumar Ramachandra, Mar 28, 2013
  7. 6/6 remote.c: introduce branch.<name>.pushremoteRamkumar Ramachandra, Mar 28, 2013
  8. Junio C HamanoMar 28, 2013
  9. Jeff KingMar 28, 2013
  10. Junio C HamanoMar 28, 2013
  11. Ramkumar RamachandraMar 31, 2013
  12. Junio C HamanoApr 1, 2013
  13. Junio C HamanoApr 1, 2013
  14. Junio C HamanoApr 1, 2013
  15. Junio C HamanoApr 1, 2013
  16. Ramkumar RamachandraMar 31, 2013
  17. Jeff KingMar 31, 2013
  18. Junio C HamanoApr 1, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.