git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: start to generate PATH_INFO URLs

From
Junio C Hamano <junkio@cox.net>
Date
Oct 3, 2006, 17:36 UTC
Message-ID
<7vfye5pai1.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20061003171229.GN2871@admingilde.org>
Martin Waitz <tali@admingilde.org> writes:
Show 8 quoted lines
> On Tue, Oct 03, 2006 at 02:16:05PM +0200, Jakub Narebski wrote:
>> 
>> I have just modified href() to be able to use it for actions which don't
>> need the ?p= parameter... and you didn't take into consideration the case
>> when $params{'project'} is set, but undefined.
>
> is this handled correctly in the second patch which got committed to
> next?

I did only a light testing last night and I do not remember testing this particular issue I did not see an obvious breakage. Could you two please verify and send in fixes if you find any more issues around this area?

I think Jakub's suggestion to respond in PATH_INFO to requests that does use PATH_INFO is a good one.

Previous: Jakub Narebski
Message 19 of 19 in “gitweb: start to generate PATH_INFO URLs”
  1. gitweb: start to generate PATH_INFO URLsMartin Waitz, Sep 29, 2006
  2. Junio C HamanoSep 29, 2006
  3. Martin WaitzSep 30, 2006
  4. Junio C HamanoSep 30, 2006
  5. gitweb: start to generate PATH_INFO URLs.Martin Waitz, Oct 1, 2006
  6. Jakub NarebskiOct 3, 2006
  7. Junio C HamanoOct 3, 2006
  8. Jakub NarebskiOct 3, 2006
  9. Junio C HamanoOct 3, 2006
  10. Martin WaitzOct 3, 2006
  11. gitweb: warn if feature cannot be overridden.Martin Waitz, Oct 3, 2006
  12. Jakub NarebskiOct 3, 2006
  13. gitweb: make PATHINFO URL generation conditional on input URL.Martin Waitz, Oct 3, 2006
  14. Petr BaudisOct 6, 2006
  15. Junio C HamanoOct 7, 2006
  16. Jakub NarebskiOct 3, 2006
  17. Martin WaitzOct 3, 2006
  18. Jakub NarebskiOct 3, 2006
  19. Junio C HamanoOct 3, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.